[discuss] [PATCH] [1/3] x86_64: mce_amd relocate sysfs files

Andi Kleen ak at suse.de
Thu May 18 00:20:23 CEST 2006


On Wednesday 17 May 2006 20:22, shin, jacob wrote:
> Get rid of /sys/devices/system/threshold directory and
> move mce_amd thresholding files into the machinecheck
> directory -- /sys/devices/system/machinecheck.

You're aware you're breaking an user ABI? You're assuming
nobody uses this yet? There are already distros out with
the old name so handling it in programs could be nasty.

That said I agree that the old location looks wrong.
Just not sure it is bad enough to break ABIs.

> 
>  #define PFX "mce_threshold: "
> -#define VERSION "version 1.00.9"
> +#define VERSION "version 1.0.10"

Should probably drop these versions because they don't get
incremented when someone else hacks the driver.

>  void mce_log(struct mce *m);
> +DECLARE_PER_CPU(struct sys_device, device_mce);

Why is this in a header and no static? 

-Andi



More information about the discuss mailing list